AMD FSR antialiasing discussion

Discussion in 'Architecture and Products' started by Deleted member 90741, May 20, 2021.

  1. DegustatoR

    Veteran

    Joined:
    Mar 12, 2002
    Messages:
    3,240
    Likes Received:
    3,393
    Unless something has changed recently Pascal never exposed FP16 support in DX/VK. The 1/64 rate was provided in CUDA only for s/w compatibility reasons. (And I'm not talking about GP100 of course.)
     
  2. iroboto

    iroboto Daft Funk
    Legend Subscriber

    Joined:
    Mar 6, 2014
    Messages:
    14,833
    Likes Received:
    18,632
    Location:
    The North
    this sounds correct with my experience. Thanks
     
  3. Here's AMD's description on the process:

    ___________________________________________________________________________________
    FidelityFX Super Resolution is a spatial upscaler: it works by taking the current anti-aliased frame and upscaling it to display resolution without relying on other data such as frame history or motion vectors.

    At the heart of FSR is a cutting-edge algorithm that detects and recreates high-resolution edges from the source image. Those high-resolution edges are a critical element required for turning the current frame into a “super resolution” image.

    FSR provides consistent upscaling quality regardless of whether the frame is in movement, which can provide quality advantages compared to other types of upscalers.
    FSR is composed of two main passes:

    • An upscaling pass called EASU (Edge-Adaptive Spatial Upsampling) that also performs edge reconstruction. In this pass the input frame is analyzed and the main part of the algorithm detects gradient reversals – essentially looking at how neighboring gradients differ – from a set of input pixels. The intensity of the gradient reversals defines the weights to apply to the reconstructed pixels at display resolution.
    • A sharpening pass called RCAS (Robust Contrast-Adaptive Sharpening) that extracts pixel detail in the upscaled image.
    FSR also comes with helper functions for color space conversions, dithering, and tone mapping to assist with integrating it into common rendering pipelines used with today’s games.

    ___________________________________________________________________________________

    To anyone who read (and is able to understand) the code, is RCAS any different from CAS?



    The lonely FP16 unit in the SM is there for compliance reasons, but real FP16 throughput should be at least the same as FP32 as the driver can probably just promote all FP16 variables and operations to FP32.

    I don't know if Pascal or Maxwell have any advantage in using FP16, by e.g. saving register data bandwidth. I know Polaris does this.
     
  4. DegustatoR

    Veteran

    Joined:
    Mar 12, 2002
    Messages:
    3,240
    Likes Received:
    3,393
    FSR seems to be a combination of Lanczos based upscaling and CAS sharpening so nothing really new and kinda explain why Lanczos upscaled screenshots look very close to what you get with FSR.
    Both passes are done in compute and can run in FP16 without quality loss.
    There are some hints that future FSR versions may use temporal approach too.

    That's another weird recommendation in AMD docs - to use FP32 on Polaris.
     
    PSman1700, iroboto and pharma like this.
  5. NThibieroz

    Newcomer

    Joined:
    Jun 8, 2013
    Messages:
    37
    Likes Received:
    77
    We've now corrected the slide deck and recommend the FP32 fallback for both Geforce 900 series and Geforce 10 series. Thanks for reporting this discrepancy!
     
  6. Cyan

    Cyan orange
    Legend

    Joined:
    Apr 24, 2007
    Messages:
    9,734
    Likes Received:
    3,460
    Necromundi Hired Gun has adopted FSR and it had DLSS support already.

    Comparison video showing the game running at FSR Ultra Quality and DLSS 2.2 Quality.

    Judge by yourself. The video doesnt show any zoomed image but the difference doesnt seem big and it performs better with FSR.

     
    Randomoneh, Krteq and sonen like this.
  7. Cyan

    Cyan orange
    Legend

    Joined:
    Apr 24, 2007
    Messages:
    9,734
    Likes Received:
    3,460
  8. Malo

    Malo Yak Mechanicum
    Legend Subscriber

    Joined:
    Feb 9, 2002
    Messages:
    8,929
    Likes Received:
    5,528
    Location:
    Pennsylvania
    Obviously DLSS is providing a better image with reconstruction, more detail. Likely better in motion as well. This is a given since it's a superior technique that we've gone over many times but will be argued back and forth for the next week. There's zero surprise here.

    Maybe some discussion can actually be had on specifically FSR without it degrading into the usual stupid wars... doubtful.
     
    PSman1700 likes this.
  9. trinibwoy

    trinibwoy Meh
    Legend

    Joined:
    Mar 17, 2004
    Messages:
    12,055
    Likes Received:
    3,109
    Location:
    New York
    At the same input resolution yes but isn't FSR ultra actually running at a higher res than DLSS quality?
     
    Putas likes this.
  10. pharma

    Veteran

    Joined:
    Mar 29, 2004
    Messages:
    4,887
    Likes Received:
    4,534
    One good thing is it looks like FSR will not require any driver changes from the Nvidia team to get an acceptable result.
     
    Lightman, Krteq and PSman1700 like this.
  11. Frenetic Pony

    Regular

    Joined:
    Nov 12, 2011
    Messages:
    807
    Likes Received:
    478
    DLSS also has some annoying aliasing, you can see interior lines with jaggies. Wish they wouldn't oversharpen or whatever is going on there, as otherwise it does look better, but those jaggy edges are going to look worse in motion as well. But then that's my preference, for a bit smoother rather than oversharpened, I always turn down sharpen filters where available.
     
    #791 Frenetic Pony, Jul 17, 2021
    Last edited: Jul 17, 2021
    no-X likes this.
  12. Kaotik

    Kaotik Drunk Member
    Legend

    Joined:
    Apr 16, 2003
    Messages:
    10,244
    Likes Received:
    4,462
    Location:
    Finland
    Yes, DLSS Quality is 1.5x scaling, FSR Ultra 1.3x
     
  13. OlegSH

    Regular

    Joined:
    Jan 10, 2010
    Messages:
    797
    Likes Received:
    1,622
    This should not matter much.

    Spatial upscaling will always be worse on pixel sized geometry without MSAA or SSAA - wires, fences, tree branches, geometry specular highlights, alpha transparent textures, such as tree branches, leaves, grass, i.e. all foliage, all other high frequency geometry details will lose definition and these details not even have to be real geometry, per pixel material blending in shaders, POM like effects, thin texture specular highlights, etc, etc, all these details will lose definition.

    All this stuff is visible in these screenshots - https://forum.beyond3d.com/threads/amd-fsr-antialiasing-discussion.62394/page-40#post-2215893

    Temporal accumulation can reconstruct these high frequency details in pure accumulation mode, but then TAA cuts off most of the mentioned high frequency details with neighborhood clipping and adds blur instead by clipping color space of history to a color space of 3x3 pixels in the last frame, that's why DLSS often looks better than native with TAA.

    Using TAA with FSR doubles losses - that's a combination of lossy neighborhood clipping with lower resolution.

    AMD suggests using FSR with lower texture mip bias and I would love to see how it affects temporal stability (would be a very bad idea to do something like this in a game with MSAA for example), neighborhood clipping in TAA is good at cutting off high frequency signal, but any texture noise that survive should be quite apparent and can be futher exaggerated by RCAS.

    TAA has it too since accumulation fails in the same cases for both, luckily aliasing can be fixed with image prefiltering with morphological AA, sad that no dev is doing this.
     
    #793 OlegSH, Jul 17, 2021
    Last edited: Jul 17, 2021
  14. DegustatoR

    Veteran

    Joined:
    Mar 12, 2002
    Messages:
    3,240
    Likes Received:
    3,393
    All these games which I don't have are getting patches.

    The code itself can probably be optimized for Nv h/w though. FP16 version may run differently on Turing and Ampere for example. 16 series may need some special care as well.
     
  15. Subtlesnake

    Regular

    Joined:
    Mar 18, 2005
    Messages:
    347
    Likes Received:
    126
  16. DegustatoR

    Veteran

    Joined:
    Mar 12, 2002
    Messages:
    3,240
    Likes Received:
    3,393
    TAAU is an UE4 feature and can be used in a number of titles which support FSR.
    Acradegeddon seem to provide TAAU as a menu option though.
     
  17. Dampf

    Regular

    Joined:
    Nov 21, 2020
    Messages:
    283
    Likes Received:
    473
    Woah, that's interesting. Does anyone here have the game and can make comparisons?

    Speaking of FP16, doesn't route Nvidia FP16 calculations through the tensor cores automatically? If so, I wonder if the upscaling cost is any different on RTX GPUs compared to RDNA2.
     
    #797 Dampf, Jul 17, 2021
    Last edited: Jul 17, 2021
  18. Subtlesnake

    Regular

    Joined:
    Mar 18, 2005
    Messages:
    347
    Likes Received:
    126
    Can you enable both at the same time though? Since that was how I understood "Hybrid Upscaling" in those patch notes.
     
  19. DegustatoR

    Veteran

    Joined:
    Mar 12, 2002
    Messages:
    3,240
    Likes Received:
    3,393
    I'm assuming it's either or situation. You can use either FSR or TAAU to upscale from some lower res to your screen. Running them both don't make much sense to me. Chances are that TAAU with some CAS on top would produce better results than TAAU+FSR.
     
    PSman1700 likes this.
  20. DavidGraham

    Veteran

    Joined:
    Dec 22, 2009
    Messages:
    3,976
    Likes Received:
    5,210
    FSR shimmers a lot.
     
    PSman1700 likes this.
Loading...

Share This Page

  • About Us

    Beyond3D has been around for over a decade and prides itself on being the best place on the web for in-depth, technically-driven discussion and analysis of 3D graphics hardware. If you love pixels and transistors, you've come to the right place!

    Beyond3D is proudly published by GPU Tools Ltd.
Loading...