How much are diagonals needed though? In those Good Old Days directions were limited to 8 ways, so you needed to be able to use them. Almost all control these days in on analogue sticks, with D-pad consigned to menu controls and function buttons. The only genre I know it to affect is fighters, and for them you're better off with a stick. For discrete buttons where left, right, up, down are used like the tri, square, circle, cross buttons, the current implementation is the best.
As for triggers, technically XB360's are the better implementation, but again how many games does it affect? For racers a smooth progressive accelerator is good, but in most games it's there as an activate button, for which I prefer the bumper design. The DS layout effectively allows for four shoulder buttons to be used in games, whereas IMO the XB360 is more a design of either you're using the triggers with your index finger, or the bumper above it.
Bear in mind of course my viewpoint is seriously skewed by years and years of PS controller use and fairly minimal XB controller use, mostly on a few shooters and lots of FIFA!
As for triggers, technically XB360's are the better implementation, but again how many games does it affect? For racers a smooth progressive accelerator is good, but in most games it's there as an activate button, for which I prefer the bumper design. The DS layout effectively allows for four shoulder buttons to be used in games, whereas IMO the XB360 is more a design of either you're using the triggers with your index finger, or the bumper above it.
Bear in mind of course my viewpoint is seriously skewed by years and years of PS controller use and fairly minimal XB controller use, mostly on a few shooters and lots of FIFA!